Dispose XmlReader in SchemaExporter when done (dotnet#103286)

omajid · web-flow · commit 56600b77a631 · 2024-07-09T11:40:30.000-04:00
diff --git a/src/libraries/System.Private.DataContractSerialization/src/System/Runtime/Serialization/SchemaExporter.cs b/src/libraries/System.Private.DataContractSerialization/src/System/Runtime/Serialization/SchemaExporter.cs
@@ -352,7 +352,8 @@ private XmlElement ExportGenericInfo(Type clrType, string elementName, string el
                 ignoreExtensionDataObject: false, preserveObjectReferences: true);
             serializer.WriteObject(xmlWriter, surrogateData);
             xmlWriter.Flush();
-            return (XmlElement?)XmlDoc.ReadNode(XmlReader.Create(new StringReader(stringWriter.ToString())));
+            using var xmlReader = XmlReader.Create(new StringReader(stringWriter.ToString()));
+            return (XmlElement?)XmlDoc.ReadNode(xmlReader);
         }
 
         [RequiresDynamicCode(DataContract.SerializerAOTWarning)]

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,8 @@ private XmlElement ExportGenericInfo(Type clrType, string elementName, string el`
`352`	`352`	`ignoreExtensionDataObject: false, preserveObjectReferences: true);`
`353`	`353`	`serializer.WriteObject(xmlWriter, surrogateData);`
`354`	`354`	`xmlWriter.Flush();`
`355`		`- return (XmlElement?)XmlDoc.ReadNode(XmlReader.Create(new StringReader(stringWriter.ToString())));`
	`355`	`+ using var xmlReader = XmlReader.Create(new StringReader(stringWriter.ToString()));`
	`356`	`+ return (XmlElement?)XmlDoc.ReadNode(xmlReader);`
`356`	`357`	`}`
`357`	`358`
`358`	`359`	`[RequiresDynamicCode(DataContract.SerializerAOTWarning)]`