-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build is failing #33
Comments
I also suggest adding a Travis Build badge to the Readme so that we know if a build is failing. |
Adding using How big of a change is it to adapt to the new scheme? It may be best to simply require altair 2.2.0+ and only support that. |
I am okay with both the options, either specifying the However, since the support was needed at some point in time, I went ahead to put up a check for the availability of a named dataset. I pushed some modifications few minutes ago which checks if the dataset named is present or not. One issue I am facing right now is testing the case when named data is specified but no dataset is passed on to altair. |
Figured out the test case. Please have a look at the PR. |
While working on the other PR, I saw that the
master
's Travis build is failing. On further investigations, I found that they were failing due to change in how Altair interpreted inline data. The earlier behavior was to keep Inline Data as it is, but now they convert it into Named Data. This was breaking our tests as we did not have support for that.Ref:
Altair Changelog
Failing Travis Builds
The text was updated successfully, but these errors were encountered: