Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renko plot type #11

Closed
phicyclist opened this issue Jan 11, 2020 · 6 comments
Closed

Renko plot type #11

phicyclist opened this issue Jan 11, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request released code merged into repo AND released to Pypi

Comments

@phicyclist
Copy link

Great start so far, solid selection of plot types. There is a group of plot types that are not defined by consistent periods of time. One of these is Renko.

It would be a fantastic benefit having the ability to simply specify:
mpf.plot(df, type='renko')

Information
https://school.stockcharts.com/doku.php?id=chart_analysis:renko
https://avilpage.com/2018/01/how-to-plot-renko-charts-with-python.html

Existing code
https://github.com/chillaranand/stocktrends
https://github.com/mementum/backtrader/blob/master/backtrader/filters/renko.py

@DanielGoldfarb
Copy link
Collaborator

Sounds like a good addition to this package. Will put it on the TODO list. Thanks for the references; will make it easier. (As always, coding contributions are also welcome). Thanks.

@DanielGoldfarb DanielGoldfarb added the enhancement New feature or request label Jan 15, 2020
@kitt-th
Copy link

kitt-th commented Jan 17, 2020

  1. i second the request for renko plots!
  2. Thanks very much for this repository - it's just what I've been looking for!

@coffincw
Copy link
Collaborator

coffincw commented Mar 5, 2020

Is this feature currently being worked on? I would be interested in giving it a shot if it isn't already being implemented.

@DanielGoldfarb
Copy link
Collaborator

@coffincw Caleb- No one is currently working on this, so please feel free to give it a shot.

When you have a good idea of how you want to implement this, before you get too far along, please communicate with me (description or pseudo-code or code). There are a couple of enhancements currently in-flight, and I would like us to coordinate so that we can avoid, or minimize, any design or merge challenges.

Again, thank you so much for contributing to this project!

All the best! --Daniel

@coffincw
Copy link
Collaborator

coffincw commented Mar 5, 2020

Sounds good! I'll send you an email with my plan when I get to it this weekend!

You're welcome! I've had a lot of fun contributing!

@coffincw
Copy link
Collaborator

coffincw commented Mar 8, 2020

#47

@DanielGoldfarb DanielGoldfarb added the merged / awaiting release to pypi code merged into repo, but not yet released to Pypi label Mar 13, 2020
@DanielGoldfarb DanielGoldfarb added released code merged into repo AND released to Pypi and removed merged / awaiting release to pypi code merged into repo, but not yet released to Pypi labels May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released code merged into repo AND released to Pypi
Projects
None yet
Development

No branches or pull requests

4 participants