Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive amout of logging #19

Open
loood opened this issue Dec 31, 2024 · 0 comments
Open

Excessive amout of logging #19

loood opened this issue Dec 31, 2024 · 0 comments

Comments

@loood
Copy link

loood commented Dec 31, 2024

My job raised concerns about the excessive amount of logging done via the print_pids function (maybe related to the way we are utilizing this).

Made a one liner change (I have no idea what I am doing) so to be able to use dynamic debug to control whether/when logging happens.

$ cat dynamic_debug.patch 
diff -r -u mpu-4cd11efbf0b9623c97fc1f977a4fa9495bfff1e3/src/mpu_ioctl.c mpu-4cd11efbf0b9623c97fc1f977a4fa9495bfff1e3.new/src/mpu_ioctl.c
--- mpu-4cd11efbf0b9623c97fc1f977a4fa9495bfff1e3/src/mpu_ioctl.c        2024-01-14 06:53:09.000000000 +0000
+++ mpu-4cd11efbf0b9623c97fc1f977a4fa9495bfff1e3.new/src/mpu_ioctl.c    2024-12-31 00:27:11.538669134 +0000
@@ -135,7 +135,7 @@
   u32 i;
   for (i = 0; i < cnt; i++, pids += off)
   {
-    printk(KERN_DEBUG "mpu: %s dump process pid %u\n", tag, *pids);
+    pr_debug("mpu: %s dump process pid %u\n", tag, *pids);
   }
 }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant