Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all space previews work #142

Closed
squahtx opened this issue Nov 1, 2022 · 3 comments · Fixed by #153
Closed

Make all space previews work #142

squahtx opened this issue Nov 1, 2022 · 3 comments · Fixed by #153
Milestone

Comments

@squahtx
Copy link
Contributor

squahtx commented Nov 1, 2022

To make space previews work, m.room.guest_access {guest_access: "can_join"} and m.room.history_visibility {history_visibility: "world_readable"} events need to be sent in all (sub)spaces.

This was partially done in #88, but that PR neglected to set m.room.guest_access for auditorium subspaces.

TODO: check if m.room.history_visibility is actually required to make space previews work.

@reivilibre
Copy link
Contributor

@squahtx Do you know why m.room.guest_access is needed? I'm looking through Synapse (and the spec... which is underspecified :/) and can't see where it comes into play.

@squahtx
Copy link
Contributor Author

squahtx commented Jan 13, 2023

I can't remember, I'm afraid. It may be to satisfy logic on Element Web?

@turt2live
Copy link
Member

Guest access allows anonymous viewers to view the room, as they otherwise would get told to go away (slightly awkward because an authenticated user could see the room, but guest users would be declined 🤷 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants