Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to @mx-puppet/matrix-discord-parser 0.1.10 #829

Merged

Conversation

jlu5
Copy link
Contributor

@jlu5 jlu5 commented Aug 11, 2022

This matrix-discord-parser update pulls in a few changes, including:

I've updated the tests to match these new behaviours.

jlu5 added 2 commits August 11, 2022 00:14
This pulls in https://gitlab.com/mx-puppet/discord/matrix-discord-parser/-/merge_requests/21, which removes matrix.to links for non-Discord user mentions

Fixes matrix-org#652
Fixes matrix-org#772

Signed-off-by: James Lu <james@overdrivenetworks.com>
Signed-off-by: James Lu <james@overdrivenetworks.com>
@jlu5 jlu5 requested a review from a team as a code owner August 11, 2022 07:24
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sound, you are one changelog file away from a merge!

For the changelog, I'd just identify what this changes for the end user (removing matrix.to links etc)

Signed-off-by: James Lu <james@overdrivenetworks.com>
@jlu5 jlu5 requested a review from Half-Shot August 11, 2022 19:08
@Half-Shot Half-Shot merged commit de0066d into matrix-org:develop Aug 11, 2022
@jlu5 jlu5 deleted the update-matrix-discord-parser branch June 8, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot @mention Matrix users in Discord strip out matrix.to hyperlinks from mentions
2 participants