Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridging broken with Dendrite 0.9.6 #841

Closed
tux93 opened this issue Sep 1, 2022 · 1 comment · Fixed by #842
Closed

Bridging broken with Dendrite 0.9.6 #841

tux93 opened this issue Sep 1, 2022 · 1 comment · Fixed by #842
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@tux93
Copy link

tux93 commented Sep 1, 2022

Describe the bug
After updating to Dendrite 0.9.6 matrix-appservice-discord no longer works and is throwing exceptions.
Also reported at Dendrite

To Reproduce
Steps to reproduce the behavior:

  1. Install Dendrite 0.9.6 and DiscordAS 3.0.0
  2. Bridge some Rooms
  3. Send some messages
  4. For every message an exception is logged, no messages are delivered to or from Discord

Expected behavior
Messages are sent to and received from Discord

Desktop (please complete the following information):

  • OS: openSUSE
  • Browser: Firefox
  • Version: 104
  • DiscordAS 3.0.0
  • Dendrite 0.9.6
  • node 16

Additional context

Sep 01 22:36:12 node[6098]: Sep-1 22:36:12.721 [DiscordAS] error: Exception thrown while handling "room.event" event TypeError: Cannot read properties of undefined (reading 'age')
Sep 01 22:36:12 node[6098]:     at MatrixEventProcessor.<anonymous> (/home/matrix-discord/matrix-appservice-discord/src/matrixeventprocessor.ts:94:28)
Sep 01 22:36:12 node[6098]:     at Generator.next (<anonymous>)
Sep 01 22:36:12 node[6098]:     at /home/matrix-discord/matrix-appservice-discord/build/src/matrixeventprocessor.js:23:71
Sep 01 22:36:12 node[6098]:     at new Promise (<anonymous>)
Sep 01 22:36:12 node[6098]:     at __awaiter (/home/matrix-discord/matrix-appservice-discord/build/src/matrixeventprocessor.js:19:12)
Sep 01 22:36:12 node[6098]:     at MatrixEventProcessor.OnEvent (/home/matrix-discord/matrix-appservice-discord/build/src/matrixeventprocessor.js:78:16)
Sep 01 22:36:12 node[6098]:     at /home/matrix-discord/matrix-appservice-discord/src/discordas.ts:211:34
Sep 01 22:36:12 node[6098]:     at Generator.next (<anonymous>)
Sep 01 22:36:12 node[6098]:     at fulfilled (/home/matrix-discord/matrix-appservice-discord/build/src/discordas.js:5:58)
Sep 01 22:36:12 node[6098]:     at processTicksAndRejections (node:internal/process/task_queues:96:5)
@Half-Shot
Copy link
Contributor

That sounds like we're relying on the unstable field age.

@Half-Shot Half-Shot added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Sep 2, 2022
@Half-Shot Half-Shot mentioned this issue Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not rely on age, use origin_server_ts matrix-org/matrix-appservice-discord
2 participants
@tux93 @Half-Shot