Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle redacts #473

Closed
Mikaela opened this issue Jul 13, 2017 · 3 comments
Closed

Handle redacts #473

Mikaela opened this issue Jul 13, 2017 · 3 comments
Labels

Comments

@Mikaela
Copy link
Contributor

Mikaela commented Jul 13, 2017

I think that if a media file is redacted, the bridge should also remove the copy of it that it has linked to IRC.

I don't know how this should be done with long pastes as the Matrix user isn't even aware when their message gets pastebinned. Maybe the appservice could tell about the paste in the admin room and when redacting warn that to get the paste removed, they will need to redact the other lines too and possibly link to the paste?

@kegsay
Copy link
Member

kegsay commented Jul 14, 2017

Redaction of media is a Matrix thing, not an IRC bridge thing. E.g I send an image, I redact it, my HS invalidates the MXC URI. IRC users click on the link, it 404s.

I don't think we should do redaction of pastebinned messages either. We fundamentally cannot redact text we have sent to IRC. The fact that we sorta can redact multi-line messages which have been pastbinned doesn't really help explain to the user that in most cases we cannot redact the message.

Closing this, but I'm happy to re-open this if I'm missing something here.

@kegsay kegsay closed this as completed Jul 14, 2017
@kegsay kegsay added the wontfix label Jul 14, 2017
@Mikaela
Copy link
Contributor Author

Mikaela commented Jul 14, 2017

I have understood that when I upload a media file, the bridge copies it and reuploads it and sends that file to IRC and when I redact the original file, the IRC link continues working.

If this is not a IRC bridge issue, where should I open this?

@t3chguy
Copy link
Member

t3chguy commented Jul 14, 2017

@Mikaela I believe no copying occurs and a direct link to the matrix.org HS's cache of the file is used. matrix-doc would be the place about such meta-issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants