config: correct typo to ensure consistency between example and code

[GovanifY]

There is a typo in the sample config file, reporting the pluginDir option as pluginsDir;
The code uses pluginDir instead (see:

matrix-bifrost/src/purple/PurpleInstance.ts

Line 19 in e222ccd

pluginDir: string;

) and isn't documented anywhere else, so it might be a nice idea to correct this typo.

[Half-Shot]

Hi @GovanifY, sorry for the late review. Can I get a:

• Changelog entry in https://github.com/matrix-org/matrix-bifrost/tree/develop/changelog.d
• Signoff as per https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off

[GovanifY]

@Half-Shot Done! The commit was already signed-off but I didn't include a changelog in the original commit as the change seemed minor enough, it's now done.

Also, what use does changelog.d really have? Couldn't you just read off the git log and bisect if something went wrong/you wanted to see changes? I could understand a properly formatted changelog of new features or breaking changes, but I don't see the point for this specific implementation.

[Half-Shot]

Also, what use does changelog.d really have? Couldn't you just read off the git log and bisect if something went wrong/you wanted to see changes? I could understand a properly formatted changelog of new features or breaking changes, but I don't see the point for this specific implementation.

I see your point, but anything user facing generally has to end up in the changelog unless it's absolutely minuscule. sample configs are one of those things I like to make obvious though.