Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/createRoom initial_state possibly incorrectly allows state_key to be omitted #309

Closed
Half-Shot opened this issue Jun 22, 2018 · 3 comments
Closed

/createRoom initial_state possibly incorrectly allows state_key to be omitted #309

Half-Shot opened this issue Jun 22, 2018 · 3 comments
Labels
A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol

Comments

@Half-Shot
Copy link
Contributor

Half-Shot commented Jun 22, 2018 •
edited by richvdh
Loading

More of a potential spec bug, but in /createRoom we describe state_key as being optional and if omitted, it should be empty string. This might not be the best approach and in the future we should require it (this came up in matrix-org/matrix-spec-proposals#1329).
@Half-Shot Half-Shot added the spec-bug Something which is in the spec, but is wrong label Jun 22, 2018
@turt2live
Copy link
Member

Not really a spec bug given the description on the label. More proposal-worthy material for a community member though.

@Half-Shot
Copy link
Contributor Author

Possibly, it's such a boring proposal though :(

@Half-Shot Half-Shot removed the spec-bug Something which is in the spec, but is wrong label Jun 22, 2018
@turt2live turt2live added the enhancement A suggestion for a relatively simple improvement to the protocol label Jul 10, 2018
@turt2live turt2live added the A-Client-Server Issues affecting the CS API label Sep 6, 2018
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@richvdh
Copy link
Member

richvdh commented Mar 23, 2023

For the record, this is referring to this:

image

I'm going to close this as a WONTFIX. If someone wants to make an MSC proposing to mandate state_key I won't stop them, but I don't see it as a priority.

@richvdh richvdh closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @richvdh @Half-Shot