Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current room upgrade behavior does not work nicely with invite-only rooms #425

Open
non-Jedi opened this issue Feb 7, 2019 · 1 comment
Assignees
Labels
A-Client-Server Issues affecting the CS API A-S2S Server-to-Server API (federation) feature Suggestion for a significant extension which needs considerable consideration

Comments

@non-Jedi
Copy link
Contributor

non-Jedi commented Feb 7, 2019

Since m.room.member events are ignored, members of the old room have no way of joining the new room unless the person who performed the room upgrade specifically invites them all.

Other cases that should be considered (thanks to kitsune for bringing them up):

  • Users who are invited to a room but don't join before a tombstone event is sent and then do join after.
  • Users who scroll to the top of an upgraded room after joining it directly and then see a reference to an old version (invite-only) room they aren't part of.
  • Admin upgrades an publically joinable room and then immediately makes it invite-only before any previous room members can join.
@turt2live
Copy link
Member

This was a highlighted part of matrix-org/matrix-spec-proposals#1502 fwiw

@turt2live turt2live added feature Suggestion for a significant extension which needs considerable consideration A-Client-Server Issues affecting the CS API labels Feb 7, 2019
@turt2live turt2live self-assigned this Aug 2, 2019
@turt2live turt2live added the A-S2S Server-to-Server API (federation) label Aug 2, 2019
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client-Server Issues affecting the CS API A-S2S Server-to-Server API (federation) feature Suggestion for a significant extension which needs considerable consideration
Projects
None yet
Development

No branches or pull requests

2 participants