Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec PUT /directory/list (SPEC-102) #417

Closed
matrixbot opened this issue Feb 2, 2015 · 9 comments
Closed

Spec PUT /directory/list (SPEC-102) #417

matrixbot opened this issue Feb 2, 2015 · 9 comments
Labels
spec-omission implemented but not currently specified

Comments

@matrixbot
Copy link
Member

PUT /_matrix/client/r0/directory/list/room/<room_id> is used to manage the visibility of rooms in the room list, but this is undocumented

(Imported from https://matrix.org/jira/browse/SPEC-102)

(Reported by @ara4n)

@matrixbot
Copy link
Member Author

Jira watchers: @ara4n @richvdh

@matrixbot
Copy link
Member Author

It's the visibility flag on createRoom, but presumably we are looking for a way to change it post-hoc?

-- @richvdh

@matrixbot
Copy link
Member Author

we have /directory/list, but that isn't specced. Updating the summary accordingly.

-- @richvdh

@matrixbot matrixbot changed the title Spec /directory/list Spec /directory/list (SPEC-102) Oct 31, 2016
@matrixbot matrixbot added the spec-bug Something which is in the spec, but is wrong label Nov 7, 2016
@matrixbot matrixbot added the spec-omission implemented but not currently specified label Nov 7, 2016
@richvdh richvdh removed the spec-bug Something which is in the spec, but is wrong label Oct 12, 2017
@richvdh richvdh changed the title Spec /directory/list (SPEC-102) Spec PUT /directory/list (SPEC-102) Oct 12, 2017
@gergelypolonkai
Copy link
Contributor

Would this mean that this would change the state of the room? If so, why do we need a separate API for this? It's pretty much the same functionality as PUT /_matrix/client/r0/rooms/{roomId}/state/{eventType}/{stateKey} under a different name.

Also, considering it has a reason, if there's a PUT, shouldn't we add DELETE, too?

@turt2live
Copy link
Member

The room directory is intenteded to be an isolated component of the homeserver, such that the "core" homeserver can work without a room directory, and a room directory can live independently of the core homeserver.

@gergelypolonkai
Copy link
Contributor

Ah, OK. So when I update a room state with join_rules, it will update the room directory, but when I update the room directory, it won’t update the rooms? Sounds a bit strange to me…

@turt2live
Copy link
Member

Updating join_rules doesn't update the directory directly. The directory pulls this information from the room.

@jevolk
Copy link
Contributor

jevolk commented Feb 22, 2018

This endpoint shouldn't exist.

@gergelypolonkai appears to be correct. The client's conveys what it wants by submitting the state event to the room's state endpoint. The client's responsibilities end there. If another operation like this takes place it's only conveying redundant information. In this case, the server has to figure out both times if the client is permitted to perform the operation and the client has to handle interaction and errors in both places.

What @turt2live is describing is at best an operation the server should be responsible for, and at worst an opaque implementation detail for the client-server/directory-server to work out internally. Furthermore, if directory listing details need to be conveyed, that can be done either in the event's content or with another event type.

Either way it means this endpoint shouldn't exist.

turt2live added a commit to turt2live/matrix-doc that referenced this issue Mar 3, 2018
Adds matrix-org#417

Signed-off-by: Travis Ralston <travpc@gmail.com>
@richvdh
Copy link
Member

richvdh commented Mar 6, 2018

fixed by #1141 thanks to @turt2live !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-omission implemented but not currently specified
Projects
None yet
Development

No branches or pull requests

5 participants