MSC2153: Add a default push rule to ignore m.reaction events #2153

jryans · 2019-07-04T12:20:04Z

Reactions are considered "metadata" that annotates an existing event and thus they should not by default trigger notifications. This adds a new default override rule that ignores reaction events for the purpose of notifications.

Rendered

FCP Checkboxes

Implementations:

anoadragon453

Looks very plausible.

proposals/2153-reaction-push-rule.md

Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

This adds a default push rule to ignore reactions as proposed in [MSC2153](matrix-org/matrix-spec-proposals#2153). By adding it here in the client directly, we can try out the idea early even if it hasn't appeared in the user's HS yet. Part of element-hq/element-web#10208

turt2live

lgtm

soliciting review from @dbkr as the push rule expert would also be ideal.

anoadragon453 · 2019-07-05T09:39:07Z

Seems like people are generally happy with this one, so:

@mscbot fcp merge

mscbot · 2019-07-05T09:39:10Z

This FCP proposal has been cancelled by #2153 (comment).

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

should not be merged until MSC1849 is ready (MSC2153: Add a default push rule to ignore m.reaction events #2153 (comment))

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

This adds a default push rule following the proposal in [MSC2153](matrix-org/matrix-spec-proposals#2153). See also element-hq/element-web#10208 See also matrix-org/matrix-js-sdk#976

uhoreg · 2019-07-05T15:25:24Z

Looks reasonable, but as a housekeeping matter:

@mscbot concern should not be merged until MSC1849 is ready

This adds a default push rule following the proposal in [MSC2153](matrix-org/matrix-spec-proposals#2153). See also element-hq/element-web#10208 See also matrix-org/matrix-js-sdk#976

KitsuneRal · 2019-08-25T07:24:52Z

I wonder if it makes sense to just merge this as a section in MSC1849.

KitsuneRal

One small thing.

KitsuneRal · 2020-06-15T17:56:38Z

proposals/2153-reaction-push-rule.md

+}
+```
+
+## Tradeoffs


Suggested change

## Tradeoffs

## Alternatives

richvdh · 2020-07-06T12:32:34Z

as a general note, I see that, as with the rest of reactions, this is already implemented and we have servers and clients relying on it.

richvdh · 2022-05-23T17:11:06Z

This is, aiui, superceded by msc2677, so

@mscbot fcp close

mscbot · 2022-05-23T17:11:08Z

Team member @mscbot has proposed to close this. The next step is review by the rest of the tagged people:

Concerns:

~~Reactions don't exist~~

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

turt2live

I'll also link to the implementations in the PR description to clear the label.

"Requested changes" to note that there's things which need to be done before merge, but not before FCP.

proposals/2153-reaction-push-rule.md

turt2live · 2022-05-31T21:01:36Z

proposals/2153-reaction-push-rule.md

+        }
+    ],
+    "actions": [
+        "dont_notify"


2624 is now matrix-org/matrix-spec#643

proposals/2153-reaction-push-rule.md

turt2live · 2022-05-31T21:05:57Z

though, we should land/FCP reactions themselves first, which is why we originally cancelled FCP. For now let's just block it:

@mscbot concern Reactions don't exist

turt2live · 2022-05-31T21:08:48Z

except I'm blind and this is for an FCP closure. Instead of chasing 8 checkboxes let's see if @jryans is okay with this MSC being incorporated into MSC2677 and close as obsolete?

@mscbot resolve Reactions don't exist

mscbot · 2022-07-19T13:07:13Z

🔔 This is now entering its final comment period, as per the review above. 🔔

mscbot · 2022-07-24T13:07:24Z

The final comment period, with a disposition to close, as per the review above, is now complete.

Add reaction push rule proposal

f4b7bdd

jryans added proposal A matrix spec change proposal proposal-in-review labels Jul 4, 2019

jryans changed the title ~~Add reaction push rule proposal~~ MSC2153: Add reaction push rule proposal Jul 4, 2019

jryans mentioned this pull request Jul 4, 2019

Reactions can trigger stuck notifications if read receipt above own messages element-hq/element-web#10208

Closed

3 tasks

jryans changed the title ~~MSC2153: Add reaction push rule proposal~~ MSC2153: Add a default push rule to ignore m.reaction events Jul 4, 2019

anoadragon453 approved these changes Jul 4, 2019

View reviewed changes

proposals/2153-reaction-push-rule.md Outdated Show resolved Hide resolved

Fix grammar error

db503c6

Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

jryans mentioned this pull request Jul 4, 2019

Add default push rule to ignore reactions matrix-org/matrix-js-sdk#976

Merged

turt2live self-requested a review July 4, 2019 14:30

turt2live approved these changes Jul 4, 2019

View reviewed changes

jryans requested a review from dbkr July 4, 2019 17:07

dbkr approved these changes Jul 5, 2019

View reviewed changes

mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Jul 5, 2019

jryans mentioned this pull request Jul 5, 2019

Add default push rule to ignore reactions matrix-org/synapse#5623

Merged

turt2live removed the proposal-in-review label Jul 10, 2019

turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020

This was referenced Jun 15, 2020

secret undocumented m.rule.reaction default push rule #2635

Closed

MSC1849: Proposal for m.relates_to aggregations #1849

Closed

KitsuneRal reviewed Jun 15, 2020

View reviewed changes

proposals/2153-reaction-push-rule.md

}

```

## Tradeoffs

Copy link

Member

KitsuneRal Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

## Tradeoffs

## Alternatives

auscompgeek mentioned this pull request Jun 16, 2020

remove unused dont_notify and coalesce push actions matrix-org/matrix-spec#643

Closed

zecakeh mentioned this pull request Feb 10, 2022

Remove as many occurrences of unstable-pre-spec feature in ruma-common as possible ruma/ruma#885

Merged

SimonBrandner mentioned this pull request May 5, 2022

MSC3786: Add a default push rule to ignore m.room.server_acl events #3786

Merged

turt2live removed the proposal-in-review label May 5, 2022

turt2live mentioned this pull request Feb 15, 2023

Some events non-obviously cause notification count changes element-hq/element-meta#1001

Open

mscbot added disposition-close proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 23, 2022

turt2live requested changes May 31, 2022

View reviewed changes

turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label May 31, 2022

mscbot added the unresolved-concerns This proposal has at least one outstanding concern label May 31, 2022

mscbot removed the unresolved-concerns This proposal has at least one outstanding concern label May 31, 2022

mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 19, 2022

mscbot closed this Jul 24, 2022

mscbot added finished-final-comment-period and removed disposition-close final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jul 24, 2022

turt2live added obsolete A proposal which has been overtaken by other proposals and removed finished-final-comment-period labels Jul 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSC2153: Add a default push rule to ignore m.reaction events #2153

MSC2153: Add a default push rule to ignore m.reaction events #2153

jryans commented Jul 4, 2019 •

edited by turt2live

Loading

anoadragon453 left a comment

turt2live left a comment

anoadragon453 commented Jul 5, 2019

mscbot commented Jul 5, 2019 •

edited

Loading

uhoreg commented Jul 5, 2019

KitsuneRal commented Aug 25, 2019

KitsuneRal left a comment

KitsuneRal Jun 15, 2020

richvdh commented Jul 6, 2020

richvdh commented May 23, 2022

mscbot commented May 23, 2022 •

edited by KitsuneRal

Loading

turt2live left a comment

turt2live May 31, 2022

turt2live commented May 31, 2022

turt2live commented May 31, 2022

mscbot commented Jul 19, 2022

mscbot commented Jul 24, 2022

MSC2153: Add a default push rule to ignore m.reaction events #2153

MSC2153: Add a default push rule to ignore m.reaction events #2153

Conversation

jryans commented Jul 4, 2019 • edited by turt2live Loading

anoadragon453 left a comment

Choose a reason for hiding this comment

turt2live left a comment

Choose a reason for hiding this comment

anoadragon453 commented Jul 5, 2019

mscbot commented Jul 5, 2019 • edited Loading

uhoreg commented Jul 5, 2019

KitsuneRal commented Aug 25, 2019

KitsuneRal left a comment

Choose a reason for hiding this comment

KitsuneRal Jun 15, 2020

Choose a reason for hiding this comment

richvdh commented Jul 6, 2020

richvdh commented May 23, 2022

mscbot commented May 23, 2022 • edited by KitsuneRal Loading

turt2live left a comment

Choose a reason for hiding this comment

turt2live May 31, 2022

Choose a reason for hiding this comment

turt2live commented May 31, 2022

turt2live commented May 31, 2022

mscbot commented Jul 19, 2022

mscbot commented Jul 24, 2022

jryans commented Jul 4, 2019 •

edited by turt2live

Loading

mscbot commented Jul 5, 2019 •

edited

Loading

mscbot commented May 23, 2022 •

edited by KitsuneRal

Loading