-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC2416: Add m.login.jwt authentication type #2416
base: old_master
Are you sure you want to change the base?
Conversation
proposals/2416-login-token.md
Outdated
A `m.login.password` auth provider could be used to log in as someone as a special user. This, | ||
however, feels rather hacky and not the intended purpose of `m.login.password`. | ||
|
||
Synapses `m.login.jwt` could be introduced properly in the spec, however, as it seems to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would prefer that, since it lets the server know which token validator to use. Otherwise the HS needs to guess, which type of token it has to validate (from what I can tell). It would also make it easier for clients to know, what login token types are supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise the HS needs to guess, which type of token it has to validate (from what I can tell).
it could guess, and on failure try other token validators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but while m.login.jwt and m.login.token do follow the same schema, putting them in the same type fails to communicate semantic information. Maybe that isn't an issue in practice, but it would seem like an issue to me as a client dev. How would I know, what token to send to a server? Just try it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you could just try it out. That being said, the JWT proposed here would be mainly for appservices to use, probably
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The m.login.token
type was removed from the spec in MSC2611 - this MSC will need to address that.
I think this MSC is talking about login types (ie, the |
It is also worth noting that |
Updated to introduce |
Synapse has also dropped support for |
Rendered
Soru is interested in providing a synapse implementation for this.
Signed-off-by: Sorunome mail@sorunome.de