Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify event format text in room version specs #3501

Merged
merged 7 commits into from
Nov 19, 2021

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 16, 2021

Split the text about event IDs and event formats into separate sections. This
is largely to make it easier to link to, but I think the resulting text makes
more sense too.

based on #3504.

Preview: https://pr3501--matrix-org-previews.netlify.app

Split the text about event IDs and event formats into separate sections. This
is largely to make it easier to link to, but I think the resulting text makes
more sense too.
@richvdh richvdh requested a review from a team November 16, 2021 18:45
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

content/rooms/fragments/v4-event-format.md Show resolved Hide resolved
version of the room containing an incoming event, so that the event can be
correctly parsed and handled. This is facilitated via changes to the
server-server API (such as the inclusion of `room_version` in the response to
`GET /_matrix/federation/v1/make_join/{roomId}/{userId}`.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this is a link, but won't fight for it

Co-authored-by: Travis Ralston <travisr@matrix.org>
@richvdh richvdh merged commit f4a0c1a into main Nov 19, 2021
@richvdh richvdh deleted the rav/room_version_event_formats branch November 19, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants