Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious logging from GroupCallEventHandler #3342

Open
ejke opened this issue May 5, 2023 · 5 comments
Open

Spurious logging from GroupCallEventHandler #3342

ejke opened this issue May 5, 2023 · 5 comments

Comments

@ejke
Copy link

ejke commented May 5, 2023

We upgraded matrix-js-sdk from 20.1.0 to 23.5.0 and somewhere between happened a change that throws bunch of console.logs.
As we are using console for actively debugging and developing also the rest of the application, it is pretty annoying.

Exaple of logs:
GroupCallEventHandler createGroupCallForRoom() processed room (roomId=\here-is-room-id-which-i-have-taken-out\)

EDIT: I found the commit that generates the issue: 31459a5

ejke referenced this issue May 5, 2023
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Copy link
Contributor

#2641 was the actual PR to add this. @dbkr, do we still need this logging?

@fnwbr
Copy link

fnwbr commented May 23, 2023

@dbkr Bump -- can you leave a comment please?

@vractal
Copy link

vractal commented Aug 26, 2023

Bumping this as the issue still exists.. Also, would this have any speed impact when starting up (not the logging, but the action behind the log)? My application does not use group calls at all, thats why I wonder

@AndreasFaust
Copy link

Is it possible to generally turn matrix logging off?

@richvdh richvdh changed the title Too many logs Spurious logging from GroupCallEventHandler Jan 21, 2025
@richvdh
Copy link
Member

richvdh commented Jan 21, 2025

Given the lack of counterargument from @dbkr, I'd assume that this logging can be removed. PRs welcome.

Is it possible to generally turn matrix logging off?

Not currently, no. It might be nice to wire up js-sdk's logging system to something like debug, but that's not possible as it stands. Again, contributions welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants