Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

[Quotes] Linebreak not behaving as expected on exiting quote #499

Closed
artcodespace opened this issue Jan 18, 2023 · 1 comment
Closed

[Quotes] Linebreak not behaving as expected on exiting quote #499

artcodespace opened this issue Jan 18, 2023 · 1 comment
Labels

Comments

@artcodespace
Copy link
Contributor

Seen in the example app on 18 Jan.

Steps to reproduce:

  • write some text (perhaps not necessary)
  • click the quote button
  • write some text
  • press enter (note same issue as code blocks where cursor does not appear to move, raised in issue [Code blocks] [Quotes] Enter does not appear to move cursor to new line #491)
  • note that linebreak appears inside the blockquote tag
  • press enter again to stop editing the quote
  • cursor moves outside the codeblock (good) but linebreak moves from inside the blockquote to the containing element

Uploading Screen Recording 2023-01-18 at 15.56.49.mov…

Expected behaviour:

  • On second press of the enter key I think that the blockquote should have the final br node removed
  • The cursor is then placed after the blockquote
@artcodespace artcodespace changed the title [Quotes] Linebreak in quote appearing in parent container on exiting quote [Quotes] Linebreak not behaving as expected on exiting quote Jan 18, 2023
@langleyd
Copy link
Contributor

langleyd commented Mar 6, 2023

Tested and no longer an issue. We don't use line breaks but paragraphs now and a paragraph is correctly started after the quote.

@langleyd langleyd closed this as completed Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants