Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event cache: Move decryption retry in there #3872

Open
1 of 4 tasks
bnjbvr opened this issue Aug 21, 2024 · 0 comments
Open
1 of 4 tasks

Event cache: Move decryption retry in there #3872

bnjbvr opened this issue Aug 21, 2024 · 0 comments

Comments

@bnjbvr
Copy link
Member

bnjbvr commented Aug 21, 2024

Right now, it's the Timeline API that takes care of retrying decryption of an event. This has a few bad consequences:

  • retrying decryption, while it could be done in other contexts than the Timeline API, can only happen there
  • some observers (e.g. the UTD hook) want to know when a previously-UTD event could be decrypted; this happens in the Timeline code too, which is an abstraction leak
  • some other code basically retries decryption on its own: the latest event code in the base crate does that

I'm proposing that we move all of this over to the Event Cache. An event in a linked chunk / on disk would be replaced by its decrypted equivalent, if needs be, and we can implement a few enhancements mentioned in a few other issues too.

Part of #3058.

@bnjbvr bnjbvr changed the title Move decryption retry into the Event Cache Event cache: Move decryption retry in there Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant