Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDU definitions and appendix section about canonical JSON disagree on maximum integer value #2485

Closed
jplatte opened this issue Apr 2, 2020 · 2 comments
Labels
s2s Server-to-Server API (federation) spec-bug Something which is in the spec, but is wrong

Comments

@jplatte
Copy link
Contributor

jplatte commented Apr 2, 2020

The section about canonical JSON states:

Numbers in the JSON must be integers in the range [-(2**53)+1, (2**53)-1].

The PDU definitons on the room version v1, v3 and v4 page all say this about the depth field:

Must be less than the maximum value for an integer (2^63 - 1).

Should the PDU definitions be updated or are they supposed to support a wider range of values than all the other integers in the spec?

@richvdh
Copy link
Member

richvdh commented Apr 2, 2020

ideally, the pdu definitions should be updated. but there's a wider problem in that synapse doesn't correctly enforce the ranges specified by canonicaljson. see: https://github.com/matrix-org/matrix-doc/issues/1646

@turt2live turt2live added s2s Server-to-Server API (federation) spec-bug Something which is in the spec, but is wrong labels Apr 2, 2020
@turt2live
Copy link
Member

This has now taken the shape of #2540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s2s Server-to-Server API (federation) spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants