Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2 Appservice login type identifier inconsistency #3709

Closed
Schuwi opened this issue Feb 5, 2022 · 1 comment · Fixed by #3711
Closed

v1.2 Appservice login type identifier inconsistency #3709

Schuwi opened this issue Feb 5, 2022 · 1 comment · Fixed by #3711
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@Schuwi
Copy link

Schuwi commented Feb 5, 2022

Link to problem area:

https://spec.matrix.org/v1.2/client-server-api/#appservice-login

Issue
The appservice login type is referred to as m.login.appservice here while in the Application Service API spec it's specified as m.login.application_service, same as in the corresponding MSC2778 and the /register route.

Expected behaviour
The identifier in Client-Server API and Application Service API specs should be consistent. I suppose the correct identifier is m.login.application_service.

@Schuwi Schuwi added the spec-bug Something which is in the spec, but is wrong label Feb 5, 2022
@Half-Shot
Copy link
Contributor

Looks like it didn't get copied into the spec properly, it's actually m.login.application_service in Synapse anyway (https://github.com/matrix-org/synapse/blob/2f053f3f82ca174cc1c858c75afffae51af8ce0d/synapse/rest/client/login.py#L73-L74) so it looks like even implementations are following the proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants