-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behaviours of Canonical JSON not thoroughly documented #1245
Comments
link to the relevant bit of spec: https://spec.matrix.org/v1.3/appendices/#canonical-json
No. I think this is implied by "Numbers in the JSON must be integers...", and certainly Synapse's behaviour here is consistent, but the spec could be more explicit. PR to clarify this would be appreciated.
pre-v6 is #1244. Post-v6 is I think clearly specced by "Numbers in the JSON must be integers in the range
Again, old rooms are #1244.
Yeah this definitely needs clarifying. The only relevant text at the moment is in the python snippet: "Encode code-points outside of ASCII as UTF-8 rather than \u escapes". The presence of the python snippet means that the behaviour is well-defined; it's just not defined in a way that is helpful for anyone not writing python. So, a PR to fix this would be very helpful.
I think this is #1246? |
Right now the spec provides a Python snippet to implement Canonical JSON:
This doesn't adequately document the actual behaviours, but instead has led us into a situation where the Python implementation is the only "correct" one.
Needs clarity to explain at least:
1e9
ever appear?)(created from #1232)
The text was updated successfully, but these errors were encountered: