Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media download endpoints do not describe a 404 response #1678

Closed
DMRobertson opened this issue Nov 24, 2023 · 3 comments
Closed

Media download endpoints do not describe a 404 response #1678

DMRobertson opened this issue Nov 24, 2023 · 3 comments
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@DMRobertson
Copy link
Contributor

DMRobertson commented Nov 24, 2023

Link to problem area:

Issue
These don't mention 404 return code, despite this being reasonable and obvious.

Expected behaviour
Synapse returns 404 in some situations: Synapse does this, e.g. https://github.com/matrix-org/synapse/blob/999bd77d3abb7b0a4430f31f5912956c3bc100ee/synapse/media/media_repository.py#L510

so we should update the spec text to reflect this.

@DMRobertson DMRobertson added the spec-bug Something which is in the spec, but is wrong label Nov 24, 2023
@turt2live
Copy link
Member

Merging into #1122

@DMRobertson
Copy link
Contributor Author

Thanks---I should have searched (harder?).

@turt2live
Copy link
Member

no worries - it took me several searches 😅

could have sworn we had an issue for it already, but turns out it was for thumbnails only (now fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

No branches or pull requests

2 participants