-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media download endpoints do not describe a 404 response #1678
Labels
spec-bug
Something which is in the spec, but is wrong
Comments
Merging into #1122 |
Thanks---I should have searched (harder?). |
no worries - it took me several searches 😅 could have sworn we had an issue for it already, but turns out it was for thumbnails only (now fixed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Link to problem area:
Issue
These don't mention 404 return code, despite this being reasonable and obvious.
Expected behaviour
Synapse returns 404 in some situations: Synapse does this, e.g. https://github.com/matrix-org/synapse/blob/999bd77d3abb7b0a4430f31f5912956c3bc100ee/synapse/media/media_repository.py#L510
so we should update the spec text to reflect this.
The text was updated successfully, but these errors were encountered: