Do not require UIA when first uploading cross-signing keys #1828
Conversation
As per MSC3967. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
| - there is no existing cross-signing master key uploaded to the homeserver, OR | ||
| - there is an existing cross-signing master key and it exactly matches the | ||
| cross-signing master key provided in the request body. If there are any additional | ||
| keys provided in the request (self-signing key, user-signing key) they MUST also | ||
| match the existing keys stored on the server. In other words, the request contains | ||
| no new keys. |
There was a problem hiding this comment.
I copied this section from the MSC, but it seems to ignore the case where a client uploads the master key and the other keys (self-signing and user-signing) separately.
My understanding according to the paragraph below is that setting the other keys if they were not set before, or re-uploading the same keys, should not require UIA, even if the master key is not part of the request (i.e. it was already uploaded before).
There was a problem hiding this comment.
The MSC (and this wording in particular) seems to imply that you have to upload the MSK on each request, otherwise you have to do UIA. I'm not sure that's what was intended, but it's probably ok, and we can't really just change it without another MSC.
| - there is no existing cross-signing master key uploaded to the homeserver, OR | ||
| - there is an existing cross-signing master key and it exactly matches the | ||
| cross-signing master key provided in the request body. If there are any additional | ||
| keys provided in the request (self-signing key, user-signing key) they MUST also | ||
| match the existing keys stored on the server. In other words, the request contains | ||
| no new keys. |
There was a problem hiding this comment.
The MSC (and this wording in particular) seems to imply that you have to upload the MSK on each request, otherwise you have to do UIA. I'm not sure that's what was intended, but it's probably ok, and we can't really just change it without another MSC.
|
LGTM other than a couple of nits. |
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
As per MSC3967.
Preview: https://pr1828--matrix-spec-previews.netlify.app