-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and sort the modules in the feature profiles table for easier skimming #1855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'd suggest we split out the adding and resorting to their own PRs. It's not immediately clear to me that this is the ordering we'd want (previously it was loosely ordered on "required-ness"). Adding the missing stuff is certainly important, though.
Ok, I can do that. Where would you suggest I insert the missing modules in the existing order? |
We typically just append them to the end, for better or worse. If they're "required" (they shouldn't be), put them under the existing required ones. |
I pushed #1860 which merely adds the three missing modules without touching the table ordering. |
83bcd73
to
83f2f8e
Compare
The brief discussion in the matrix-spec room was, sadly, inconclusive. The suggested options so far are:
As a middleground, I updated the PR to match option 4 but also renamed those rows where the module name didn't match the section title. This should hopefully still make it easy enough to cross-reference the table with the sections. For convenience, the PR can be reviewed by commit: |
CC @uhoreg / @anoadragon453 since you participated in the chat in matrix-spec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to abstain from reviewing this one - the order doesn't bother me.
This renames the modules in the table to match the section titles and orders the table alphabetically within the two subsections of modules with and without requirements.
Adding the modules that were missing in v1.10 has been moved out into #1860.
Fixes: #1437
Pull Request Checklist
Preview: https://pr1855--matrix-spec-previews.netlify.app