Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth rules spec conflicts with C-S API spec about what happens before the first power-levels event #494

Closed
richvdh opened this issue Jul 1, 2019 · 3 comments
Labels
A-Client-Server Issues affecting the CS API A-S2S Server-to-Server API (federation) spec-bug Something which is in the spec, but is wrong

Comments

@richvdh
Copy link
Member

richvdh commented Jul 1, 2019

The auth rules say: 'If there is no previous m.room.power_levels event in the room, allow'. But the C-S API says: 'If the room contains no m.room.power_levels event, the room's creator has a power level of 100, and all other users have a power level of 0' - and makes no exception for power_levels. This is, at best, confusing.

My assumption, working from the C-S spec had been that power-levels above 100 were impossible. We should figure out if PLs above 100 are a supported thing.

@grinapo
Copy link
Contributor

grinapo commented Jul 1, 2019

The latter would probably cover the exceptional case where a room has been created but there were no PL structures defined at creation. Apart from that probably all rooms is (and would be) created with m.room.power_level at creation, possibly by using power_level_content_override (c2s) which is specifically there to provide PL structure different from the defaults.

@richvdh
Copy link
Member Author

richvdh commented Jul 1, 2019

@grinapo remember that all events have to follow the auth rules, even those created during the room-creation process. The first power-level event (ie, the one created by createRoom) is therefore authorised by other homeservers based on the default power-levels, which are, in theory, those written in the C-S API.

@turt2live turt2live added A-Client-Server Issues affecting the CS API A-S2S Server-to-Server API (federation) spec-bug Something which is in the spec, but is wrong labels Jul 5, 2019
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@richvdh
Copy link
Member Author

richvdh commented Mar 31, 2023

I don't think there's a conflict here. #5 (comment) explains why it's possible to have PL>100.

@richvdh richvdh closed this as completed Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client-Server Issues affecting the CS API A-S2S Server-to-Server API (federation) spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

No branches or pull requests

3 participants