Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appservice API requires access_token to be in the query parameters #923

Closed
Half-Shot opened this issue Nov 8, 2021 · 1 comment
Closed
Labels
A-Application-Services Issues affecting the AS API security wart A point where the protocol is inconsistent or inelegant

Comments

@Half-Shot
Copy link
Contributor

It's generally agreed upon that headers are a better place for tokens, to reduce accidental publishing of tokens in the logs. It would be nicer to support headers instead of insecure query parameters, but would require bridges and homeservers to both start using the new header.

Perhaps the best approach is for homeservers to start publishing it in both places, and deprecate query parameters. Once enough time has passed, we could drop query parameters entirely.

Unfortunately this does get into the weeds of versioning, as this would be a globally breaking change.

@Half-Shot Half-Shot added wart A point where the protocol is inconsistent or inelegant A-Application-Services Issues affecting the AS API security labels Nov 8, 2021
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 2, 2022
@richvdh
Copy link
Member

richvdh commented Jun 9, 2022

Duplicate of #679

@richvdh richvdh marked this as a duplicate of #679 Jun 9, 2022
@richvdh richvdh closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Application-Services Issues affecting the AS API security wart A point where the protocol is inconsistent or inelegant
Projects
None yet
Development

No branches or pull requests

2 participants