Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename seshat-node package #9

Closed
jryans opened this issue Nov 6, 2019 · 6 comments
Closed

Rename seshat-node package #9

jryans opened this issue Nov 6, 2019 · 6 comments

Comments

@jryans
Copy link
Contributor

jryans commented Nov 6, 2019

It seems a bit strange for the package on npm to be called seshat-node... The node bit is quite redundant, since that's why it's on npm in the first place.

Have a directory seshat-node seems fine, but it'd be nice to change the package name in package.json so that it feels more natural to use.

@poljar
Copy link
Collaborator

poljar commented Nov 6, 2019

There is already a package on npm called seshat. Unless we want to scope the package somehow we can't use just seshat, no?

@jryans
Copy link
Contributor Author

jryans commented Nov 6, 2019

Hmm... I am tempted to say we should create an org and have a scoped package then. That would communicate the purpose more clearly without redundant words. I'll raise the idea and see where it takes us.

@jryans jryans changed the title Rename seshat-node package to seshat Rename seshat-node package Nov 6, 2019
@jryans
Copy link
Contributor Author

jryans commented Nov 6, 2019

Alternatively, we could go with a less obscure name like matrix-search-indexer as @dbkr suggests.

@poljar
Copy link
Collaborator

poljar commented Nov 6, 2019

Eh, I'm kinda fond of the Seshat name especially since we did get the seshat crate name on crates.io. Can't we maybe use matrix-seshat on npm to differentiate it from the existing seshat on npm as well as remove the redundancy that's present in seshat-node?

@jryans
Copy link
Contributor Author

jryans commented Nov 6, 2019

Ah yes, matrix-seshat seems workable as well. 😄

@poljar poljar mentioned this issue Nov 6, 2019
@poljar
Copy link
Collaborator

poljar commented Nov 6, 2019

Ok, I'll rename it to matrix-seshat in that case.

@poljar poljar closed this as completed in 3e085e5 Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants