Add Dockerfile (Updated) #290

tristanlins · 2020-04-05T10:58:27Z

This is the successor or a revised version of #80
From the original PR I picked the two essential / sensible commits.
Instead of using the environment variables at runtime, you can now overwrite the defaults. In particular, it's all about SYDENT_DB_PATH.

A build on top of v2.0.0 can be found here: https://github.com/tristanlins/sydent/tree/feature-docker-v2.0.0
A pre-build image can be found on docker hub: https://hub.docker.com/r/tril/matrixdotorg-sydent/tags

Changelog

(non docker file related changes)

Improve the database migration logging.
The environment variables SYDENT_SERVER_NAME, SYDENT_PID_FILE and SYDENT_DB_PATH can be used to adapt the automatically created configuration at startup.

Signed-off-by: Tristan Lins <tristan@lins.io>

… mount Signed-off-by: Tristan Lins <tristan@lins.io>

Signed-off-by: Tristan Lins <tristan@lins.io>

tristanlins · 2020-04-06T09:44:55Z

I made some more optimisations on the dockerfile.

Image size reduced from ~394MB to ~197MB
Run as user sydent not root (for security)

Signed-off-by: Tristan Lins <tristan@lins.io>

tristanlins · 2020-04-07T07:34:13Z

The user sydent is now a system user and has a fixed id (<1000).
This reduces access to the data by regular users.
And the fixed ID ensures that the user's ID does not change accidentally.

tristanlins · 2020-04-07T07:40:54Z

~~I still have a few problems with configuration via environment variables. However, I have the impression that the problem has nothing to do with Docker, but with the handling of the default values.~~ 🤔

tristanlins · 2020-04-15T18:41:52Z

I could no longer reproduce my problem when testing, I don't know exactly what was going on.

This Docker image is already running productively for me 😎

anoadragon453

Thanks for this! Just a small change.

README.rst

richvdh · 2020-06-05T10:26:40Z

@tristanlins are you still interested in working on this? It's been a few weeks since the last update here: would you be able to answer @anoadragon453's questions?

tristanlins · 2020-06-08T07:20:33Z

Sorry, I hat lost focus on this issue 😁
I had already replied to @anoadragon453, but had received no reply.
I have marked it as done for now, but I can make adjustments again.

anoadragon453

I had already replied to @anoadragon453, but had received no reply.

Do you mean #290 (comment)? That was only posted yesterday, and your comment 20m later. That's not a lot of time to respond :D

Anywho, thank you for the explanation 👍 I've become more familiar with Dockerfiles over the past couple weeks and thus feel more confident in reviewing this now. As such, I've left a few comments and questions below. Thank you!

.dockerignore

.gitignore

Dockerfile

README.rst

tristanlins · 2020-06-10T05:23:52Z

Do you mean #290 (comment)? That was only posted yesterday, and your comment 20m later. That's not a lot of time to respond :D

I'm really sorry, I had written the comment for a long time, but somehow it wasn't published. 🙈 (The new review management from Github still confuses me regularly ...)

I will incorporate the suggestions later.

anoadragon453 · 2020-06-10T11:42:18Z

I'm really sorry, I had written the comment for a long time, but somehow it wasn't published.

Ahh, no worries, I've done the exact same thing before :)

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Signed-off-by: Tristan Lins <tristan@lins.io>

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Signed-off-by: Tristan Lins <tristan@lins.io>

tristanlins · 2020-06-11T11:27:47Z

Done, @anoadragon453 I'm looking forward to your feedback 😀

Signed-off-by: Tristan Lins <tristan@lins.io>

anoadragon453

This LGTM! Thank you very much!

…cker * 'master' of github.com:matrix-org/sydent: changelog: OpenID auth tokens -> access tokens 2.0.1 Add newsfile Raise IncorrectSessionTokenException instead of returning it Fix documentation for testing skipping the deletion of 3PID invite tokens Cleanup and document tests for 3PID invites Fix checking for access_token query parameter (matrix-org#294) Update pyproject.toml Fix project name in pyproject.toml Add towncrier config Do a deep copy of the config default when parsing a dict Add test cases for invite deletion Add a config option to disable deleting tokens on bind

turt2live and others added 12 commits April 5, 2020 11:15

Add a dockerfile

179068f

Add debug logging around the sqlite db migrations

7e5b860

Allow overwrite config defaults with environment variables

4df9481

Signed-off-by: Tristan Lins <tristan@lins.io>

[Docker] use python 3 base image

d040e22

Signed-off-by: Tristan Lins <tristan@lins.io>

[Docker] fixup sydent pip install command

444dc33

Signed-off-by: Tristan Lins <tristan@lins.io>

[Docker] put pid file into data volume

e32fa06

Signed-off-by: Tristan Lins <tristan@lins.io>

[Docker] Update docker run example with new env variable and volume…

62ec887

… mount Signed-off-by: Tristan Lins <tristan@lins.io>

[Docker] document docker environment variables

b234617

Signed-off-by: Tristan Lins <tristan@lins.io>

[Docker] Install sentry-sdk

cc605c5

Signed-off-by: Tristan Lins <tristan@lins.io>

Add *.iml to .gitignore

7e2f9d3

[Docker] Reduce image size

e49c9af

Signed-off-by: Tristan Lins <tristan@lins.io>

[Docker] Run with user sydent

26fdfd3

Signed-off-by: Tristan Lins <tristan@lins.io>

richvdh mentioned this pull request Apr 6, 2020

Dockerfile and minor cleanup #80

Closed

[Docker] Use system account with fixed user id

be47190

Signed-off-by: Tristan Lins <tristan@lins.io>

tristanlins mentioned this pull request Apr 7, 2020

Provide official Docker image #173

Closed

clokep requested a review from a team April 15, 2020 19:13

anoadragon453 requested changes Apr 20, 2020

View reviewed changes

README.rst Outdated Show resolved Hide resolved

anoadragon453 added the awaiting changes label Jun 4, 2020

richvdh removed the awaiting changes label Jun 8, 2020

richvdh assigned anoadragon453 Jun 8, 2020

anoadragon453 self-requested a review June 9, 2020 13:42

anoadragon453 requested changes Jun 9, 2020

View reviewed changes

tristanlins and others added 4 commits June 11, 2020 10:00

Exclude vscode files from docker build

cba71ea

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Exclude vscode files from git repository

190e2da

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Add port binding to docker example

92fe8c9

Signed-off-by: Tristan Lins <tristan@lins.io>

Detailed example of persistent data in the docker container

3eb2286

Signed-off-by: Tristan Lins <tristan@lins.io>

erikjohnston requested a review from anoadragon453 June 11, 2020 09:59

tristanlins and others added 4 commits June 11, 2020 13:11

[README] Fix typo

cfd7530

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

[README] Replace "Docker default" with "Dockerfile default"

cac4a6b

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

[gitignore] _trial_temp are development files

f0aa069

[Docker] Pin to python 3.8

afc0b3e

Signed-off-by: Tristan Lins <tristan@lins.io>

[README] Fixup rst typo

96d54f1

Signed-off-by: Tristan Lins <tristan@lins.io>

anoadragon453 approved these changes Jun 11, 2020

View reviewed changes

anoadragon453 added 2 commits June 11, 2020 16:16

Add changelog

25c10ae

anoadragon453 merged commit de80990 into matrix-org:master Jun 11, 2020

trickert76 mentioned this pull request Jan 13, 2022

Publish updated Docker image #483

Closed

DMRobertson mentioned this pull request Feb 10, 2022

Dockerfile that builds with poetry #493

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Dockerfile (Updated) #290

Add Dockerfile (Updated) #290

tristanlins commented Apr 5, 2020 •

edited

Loading

tristanlins commented Apr 6, 2020

tristanlins commented Apr 7, 2020

tristanlins commented Apr 7, 2020 •

edited

Loading

tristanlins commented Apr 15, 2020 •

edited

Loading

anoadragon453 left a comment

richvdh commented Jun 5, 2020

tristanlins commented Jun 8, 2020

anoadragon453 left a comment

tristanlins commented Jun 10, 2020

anoadragon453 commented Jun 10, 2020

tristanlins commented Jun 11, 2020

anoadragon453 left a comment

Add Dockerfile (Updated) #290

Add Dockerfile (Updated) #290

Conversation

tristanlins commented Apr 5, 2020 • edited Loading

Changelog

tristanlins commented Apr 6, 2020

tristanlins commented Apr 7, 2020

tristanlins commented Apr 7, 2020 • edited Loading

tristanlins commented Apr 15, 2020 • edited Loading

anoadragon453 left a comment

Choose a reason for hiding this comment

richvdh commented Jun 5, 2020

tristanlins commented Jun 8, 2020

anoadragon453 left a comment

Choose a reason for hiding this comment

tristanlins commented Jun 10, 2020

anoadragon453 commented Jun 10, 2020

tristanlins commented Jun 11, 2020

anoadragon453 left a comment

Choose a reason for hiding this comment

tristanlins commented Apr 5, 2020 •

edited

Loading

tristanlins commented Apr 7, 2020 •

edited

Loading

tristanlins commented Apr 15, 2020 •

edited

Loading