Add a config option to disable deleting tokens on bind #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babolivier
force-pushed
the
babolivier/delete_config
branch
from
7a1180a to
0fcbe86
Compare
babolivier
force-pushed
the
babolivier/delete_config
branch
from
5f19af8 to
70975a2
Compare
This is to avoid editing the defaults directly rather than the copy.
richvdh
reviewed
May 20, 2020
…kens Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#174 introduced an automatic deletion process for 3PID invite tokens, along with their metadata, upon a successful delivery of these tokens to a homeserver following a bind of the invited 3PID.
Some admins would like to be able to keep these invites in the database to investigate issues or for audit purposes. This PR introduces a
delete_tokens_on_bindwhich, if false, skip that deletion step. It defaults to true, in order to default to a more privacy-respectful behaviour.We don't have to care about delivered invites getting in the way and being redelivered, since #165 takes care of filtering them out.