Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out setting a next link when validating a 3PID is broken since the Python 3 work. Briefly,
request.args
stores its keys asbytes
, so'nextLink' in request.args
works in Python 2 but not in Python 3.The fix for this is to use
get_args
, which does the right thing in that regards, and has support for optional arguments since #294.I assume I missed this when adding Python 3 compatibility because I was assuming
get_args
was the only way Sydent extracts arguments from a requests - turns out I missed that bit which was doing it another way. There doesn't seem to be other occurrences of that bug (looks like the only occurrence ofrequest.args
in the whole codebase is inget_args
).