Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/store-invite is returning key_validity_urls that aren't URLs #327

Closed
turt2live opened this issue Jan 7, 2021 · 4 comments
Closed

/store-invite is returning key_validity_urls that aren't URLs #327

turt2live opened this issue Jan 7, 2021 · 4 comments

Comments

@turt2live
Copy link
Member

It's returning a path rather than a URL for key_validity_url in public_keys.

@clokep
Copy link
Member

clokep commented Jan 11, 2021

@turt2live Was this seen for a particular sydent install?

The code around this is:

baseUrl = "%s/_matrix/identity/api/v1" % (self.sydent.cfg.get('http', 'client_http_base'),)
keysToReturn = []
keysToReturn.append({
"public_key": pubKeyBase64,
"key_validity_url": baseUrl + "/pubkey/isvalid",
})
keysToReturn.append({
"public_key": ephemeralPublicKeyBase64,
"key_validity_url": baseUrl + "/pubkey/ephemeral/isvalid",
})

Which seems to use http.client_http_base, maybe that's erroneously set to ""?

@turt2live
Copy link
Member Author

I was seeing this in a local setup. Might be another instance of #314 or some variation of the config being complicated?

@clokep
Copy link
Member

clokep commented Jan 12, 2021

I suspect this is another case of the default config being confusing. 😢

@turt2live
Copy link
Member Author

It is :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants