Flake8 linting of sydent/ and tests/ directories #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sitting on this until we get the Black PR (#344) merged; will review then |
added 8 commits
May 27, 2021 11:54
|
Here's the version of these files-all flake8 errors were fixed (or muted where I thought appropriate) except for the F401 errors which I just wanted to check in about. |
H-Shay
changed the title
H-Shay
changed the title
|
Hopefully this is it for the flake8 linting! Tests/ only had a few small changes and matrix_is_tests had none so I think we are good here, except for the F401 errors question I had-once that's resolved I can update the PR and we should be good to go. |
clokep
reviewed
May 28, 2021
| # name. The common name of the certificate we use for tests is fake.server. | ||
| config = { | ||
| "general": {"server.name": "fake.server"}, | ||
| "crypto": { | ||
| "ed25519.signingkey": "ed25519 0 b29eXMMAYCFvFEtq9mLI42aivMtcg4Hl0wK89a+Vb6c" | ||
| "ed25519.signingkey": "ed25519 0 b29eXMMAYCFvFEtq9mLI42aivMtcg4Hl0wK89a+Vb6c" # noqa: E501 |
There was a problem hiding this comment.
It might make more sense to globally disable E501 like we do for Synapse (for the same reasoning, that black handles it for us).
2 tasks
|
Revised and continued in #347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of running flake8 on all the .py files in the sydent/ directory (including subdirectories where applicable). It's a lot of changes which I sort of broke out and tried to group logically by committing all the modified files in each subdirectory together. I stopped before doing the tests/ directory and matrix_is_tester/ directory just because this seemed like a lot of changes and I also wanted to make sure I was doing this right-if not I didn't want to dig myself too big of a hole!
Just FYI I know the buildkite CI tests are gonna fail so i want to note that the unit tests are passing locally and that the matrix_is_tester tests are passing/failing in the same exact ratio they were before I started.