Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant type hints from docstrings. #367

Merged
merged 14 commits into from
Jun 24, 2021

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Jun 22, 2021

This PR removes redundant type hints from docstrings in sydent.

Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question!

changelog.d/366.misc Outdated Show resolved Hide resolved
sydent/sms/openmarket.py Show resolved Hide resolved
@H-Shay H-Shay requested a review from clokep June 22, 2021 19:19
@clokep clokep changed the title Revome redunant type hints from docstrings. Remove redundant type hints from docstrings. Jun 22, 2021
@H-Shay H-Shay requested a review from clokep June 24, 2021 16:19
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@clokep clokep merged commit 2e3b757 into matrix-org:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants