Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the provided web client in the HTML email. #380

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Use the provided web client in the HTML email. #380

merged 3 commits into from
Sep 2, 2021

Conversation

clokep
Copy link
Member

@clokep clokep commented Sep 2, 2021

This is a bug from #326 where the web_client_location parameter was only used in the text version of the email, not also in the HTML version.

I noticed this while reviewing #376.

@clokep clokep requested a review from a team September 2, 2021 12:15
DMRobertson
DMRobertson reviewed Sep 2, 2021
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible! Is there any way this could cause a breakage? What happens if web_client_location is not set in config?

@babolivier
Copy link
Contributor

What happens if web_client_location is not set in config?

Then https://app.element.io is used according to the config defaults.

babolivier
babolivier approved these changes Sep 2, 2021
View reviewed changes
changelog.d/380.bugfix Outdated Show resolved Hide resolved
@clokep @babolivier
Clarify changelog.
cb19171 
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
@clokep
Copy link
Member Author

clokep commented Sep 2, 2021

In-case it isn't clear, web_client_location is already used in all those templates, it was just not used in all of the places it should have been!

Thank you for the review!

@clokep clokep merged commit ac2b646 into main Sep 2, 2021
@clokep clokep deleted the clokep/web-cl-loc branch September 2, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson left review comments

@babolivier babolivier babolivier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clokep @babolivier @DMRobertson