Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the use of the migration script #386

Merged
merged 5 commits into from
Sep 8, 2021
Merged

Document the use of the migration script #386

merged 5 commits into from
Sep 8, 2021

Conversation

babolivier
Copy link
Contributor

No description provided.

@babolivier babolivier requested a review from a team September 8, 2021 14:22
squahtx
squahtx approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@squahtx squahtx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 typo

squahtx
squahtx reviewed Sep 8, 2021
View reviewed changes
docs/casefold_migration.md Outdated Show resolved Hide resolved
reivilibre
reivilibre approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for doing this!

The thing about delete/dissociate: I'm leaving to your opinion (since it's not critical here, I don't like either one all that much).

docs/casefold_migration.md Outdated Show resolved Hide resolved
docs/casefold_migration.md Outdated Show resolved Hide resolved
docs/casefold_migration.md Outdated Show resolved Hide resolved
docs/casefold_migration.md Outdated Show resolved Hide resolved
docs/casefold_migration.md Outdated Show resolved Hide resolved
docs/casefold_migration.md Outdated Show resolved Hide resolved
babolivier
babolivier commented Sep 8, 2021
View reviewed changes
docs/casefold_migration.md Outdated Show resolved Hide resolved
babolivier and others added 2 commits September 8, 2021 17:13
@babolivier @reivilibre
Apply suggestions from code review
b590032 
Co-authored-by: reivilibre <38398653+reivilibre@users.noreply.github.com>
@babolivier @reivilibre
Update docs/casefold_migration.md
1485270 
Co-authored-by: reivilibre <38398653+reivilibre@users.noreply.github.com>
@babolivier babolivier merged commit 54d2c8e into main Sep 8, 2021
@babolivier babolivier deleted the babolivier/migration_doc branch September 8, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squahtx squahtx squahtx approved these changes

@reivilibre reivilibre reivilibre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babolivier @squahtx @reivilibre