Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider doing fewer retries for APNS #116

Closed
richvdh opened this issue May 11, 2020 · 2 comments · Fixed by #133
Closed

consider doing fewer retries for APNS #116

richvdh opened this issue May 11, 2020 · 2 comments · Fixed by #133
Assignees

Comments

@richvdh
Copy link
Member

richvdh commented May 11, 2020

if we have problems with APNS, we retry each request at 10s and 20s intervals. Given that haproxy limits the number of concurrent requests to sygnal, this can easily mean that the haproxy<->signal connection pool gets saturated with failing APNS requests, so that very few GCM requests get a look-in.

We should consider doing fewer retries, or doing them faster, or marking APNS as down and failing the request more quickly.

Really, we need a mechanism to indicate to homeservers that a push failed (https://github.com/matrix-org/matrix-doc/issues/2534).

@richvdh
Copy link
Member Author

richvdh commented May 11, 2020

Also: apnspushkin makes 3 attempts, and then for each attempt, aioapns makes 4 attempts (we set pool.max_connection_attempts=3, but I think there is an off-by-one error in aioapns). Is all that really needed?

@richvdh
Copy link
Member Author

richvdh commented May 11, 2020

see #104 for a bit of background on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants