Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts-dev/lint.sh #243

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Add scripts-dev/lint.sh #243

merged 3 commits into from
Aug 10, 2021

Conversation

reivilibre
Copy link
Contributor

No description provided.

@reivilibre reivilibre requested a review from a team August 5, 2021 13:52
@callahad
Copy link
Contributor

callahad commented Aug 5, 2021

Can I ask what the motivation is for this PR?

@reivilibre
Copy link
Contributor Author

We have this very useful script in Synapse which runs all the lints; as a matter of convenience and consistency, it seemed a good idea to have it here also.

@clokep
Copy link
Member

clokep commented Aug 5, 2021

I usually attempt to run this for sygnal and sydent and then cry and look at CI configs to see what I'm supposed to run. I'd love to have this! :)

scripts-dev/lint.sh Outdated Show resolved Hide resolved
files=(
"sygnal"
"tests"
"scripts-dev/old_deps.py"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to do the whole directory?

reivilibre and others added 2 commits August 6, 2021 10:22
Co-authored-by: Erik Johnston <erik@matrix.org>
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@reivilibre reivilibre merged commit da52ed7 into main Aug 10, 2021
@reivilibre reivilibre deleted the rei/lintsh branch August 10, 2021 09:37
reivilibre added a commit that referenced this pull request Aug 10, 2021
Co-authored-by: Erik Johnston <erik@matrix.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants