Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub Action CI check to ensure Dockerfile changes actually work #248

Merged
merged 8 commits into from
Aug 10, 2021

Conversation

reivilibre
Copy link
Contributor

Signed-off-by: Olivier Wilkinson (reivilibre) olivier@librepush.net

@reivilibre reivilibre requested a review from a team August 9, 2021 18:57
@reivilibre
Copy link
Contributor Author

The trail of CI runs and commits above show that when the docker build is broken, you get a red cross ^.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@reivilibre reivilibre merged commit 6d62a28 into main Aug 10, 2021
@reivilibre reivilibre deleted the rei/docker_in_ci branch August 10, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants