Add prometheus metric for the number of requests in flight. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By having a FakeChannel instead of a DummyRequest, we can make sure that functionality which relies on our own Request impl works correctly.
richvdh
force-pushed
the
rav/in_flight_metrics
branch
from
0e524ee
to
5824b0b
Compare
erikjohnston
changed the title
| ) | ||
| async def cb(): | ||
| with request.processing(): | ||
| await self._handle_dispatch(root_span, request, log, notif, context) |
There was a problem hiding this comment.
Can we not just instead do:
with REQUESTS_IN_FLIGHT_GUAGE.track_inprogress():
await self._handle_dispatch(root_span, request, log, notif, context)rather than having the request itself track what's going on? Or can we finish the request independently of the _handle_dispatch?
There was a problem hiding this comment.
well, the intention was to lay the groundwork for tracking requests in progress when we have other servlets which don't necessarily follow the same pattern. In principle, yes we can finish a request independently of the async handler - for example if we hand over control to a Producer to stream back a response.
In practice, we dont' do that anywhere in sygnal and honestly I guess it's unlikely that we ever will. So yeah, this is over-engineered. I'll simplify it.
realistically, we just need to bump the metric around the async handler.
erikjohnston
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #85