Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Singleton for blacklisting http client #26

Open
anoadragon453 opened this issue Feb 25, 2020 · 0 comments
Open

Singleton for blacklisting http client #26

anoadragon453 opened this issue Feb 25, 2020 · 0 comments

Comments

@anoadragon453
Copy link
Member

https://github.com/matrix-org/synapse/blob/bbf8886a05be6a929556d6f09a1b6ce053a3c403/synapse/handlers/identity.py#L55

Should be changed to hs.get_blacklisting_http_client, to allow for easier unit testing.

We should also stop saying it's the federation blacklist since we've applied it in many different places now.

... though there is an argument to being able to have multiple blacklists for different outgoing parts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant