Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Run CI against Twisted's "trunk" branch #10340

Closed
callahad opened this issue Jul 8, 2021 · 4 comments · Fixed by #10651
Closed

Run CI against Twisted's "trunk" branch #10340

callahad opened this issue Jul 8, 2021 · 4 comments · Fixed by #10651
Labels
good first issue Good for newcomers P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@callahad
Copy link
Contributor

callahad commented Jul 8, 2021

We're a big / complex enough project to where testing against trunk would be genuinely valuable for the broader Twisted ecosystem.

This would likely take the form of a scheduled GitHub Action which runs our test suite once a day, using Twisted's trunk branch instead of whatever version is specified in our dependencies.

@callahad callahad added good first issue Good for newcomers P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Jul 8, 2021
@ShadowJonathan
Copy link
Contributor

How would the signalling of a failed job for this go? A matrix room?

@callahad
Copy link
Contributor Author

callahad commented Jul 8, 2021

I believe GitHub Actions sends repo owners a notification when a scheduled job fails, similar to how it notifies you when your own PR fails.

@richvdh
Copy link
Member

richvdh commented Jul 19, 2021

We're a big / complex enough project to where testing against trunk would be genuinely valuable for the broader Twisted ecosystem.

This will also bring a more direct benefit to the Synapse project: it will give us early warning of any compatibility problems in the next version of Twisted.

@richvdh
Copy link
Member

richvdh commented Jul 20, 2021

I've been wondering how we could best approach this. I'm assuming we want to run at least {mypy, trial, sytest, complement} on Synapse with pip install https://github.com/twisted/twisted/archive/trunk.zip.

Of those, I think the hardest is going to be sytest, because the incantations for setting up and running Synapse are all embedded within the sytest-synapse docker image.

Possibly we could do some sed on python-dependencies before we start the test runs, to replace the Twisted dependency with trunk instead of 18.whatever?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants