Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

knock events sent over federation have no state but are not marked as outliers #10872

Closed
richvdh opened this issue Sep 21, 2021 · 1 comment · Fixed by #10873
Closed

knock events sent over federation have no state but are not marked as outliers #10872

richvdh opened this issue Sep 21, 2021 · 1 comment · Fixed by #10873
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@richvdh
Copy link
Member

richvdh commented Sep 21, 2021 •
edited
Loading

when we send out a knock event, we persist the sent event in the events table, but do not mark it out as an outlier.

We give it a state_group, but that state_group contains only the knock event itself.
@richvdh
Copy link
Member Author

richvdh commented Sep 21, 2021 •
edited
Loading

I'm not entirely sure what the effects of this will be, but it certainly isn't a good thing for the consistency of the room state and the DAG.

@richvdh richvdh mentioned this issue Sep 22, 2021
Merged
@erikjohnston erikjohnston added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure we mark sent knocks as outliers matrix-org/synapse
2 participants
@richvdh @erikjohnston