Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Include bundled events when requesting relations #11087

Closed
Tracked by #3
clokep opened this issue Oct 14, 2021 · 0 comments · Fixed by #11284
Closed
Tracked by #3

Include bundled events when requesting relations #11087

clokep opened this issue Oct 14, 2021 · 0 comments · Fixed by #11284
Assignees
Labels
A-Threads Threaded messages T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-p2 (Deprecated Label)

Comments

@clokep
Copy link
Member

clokep commented Oct 14, 2021

In order for MSC3440 to be successful it proposes being explicit about the behavior in MSC2675 that the /relations API should include the bundled relations of each returned event.

The behavior here was changed a few times:

The proposal here is to include them on the relations event. Note that #5654 includes the following:

We also do this when pulling the relation events as well, because edits of edits are not something we'd like to support here.

The code in question lies at:

# Similarly, we don't allow relations to be applied to relations, so we
# return the original relations without any aggregations on top of them
# here.
serialized_events = await self._event_serializer.serialize_events(
events, now, bundle_aggregations=False
)

Which asserts that we don't allow relations to relations, but I don't think this is accurate. If this is a problem for edits we might need to solve this a different way.

@clokep clokep self-assigned this Oct 14, 2021
@clokep clokep added P2 T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Oct 14, 2021
@clokep clokep added the A-Threads Threaded messages label Oct 15, 2021
@kittykat kittykat added the z-p2 (Deprecated Label) label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Threads Threaded messages T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-p2 (Deprecated Label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants