Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

stop using REPEATABLE READ everywhere #11567

Open
richvdh opened this issue Dec 13, 2021 · 2 comments
Open

stop using REPEATABLE READ everywhere #11567

richvdh opened this issue Dec 13, 2021 · 2 comments
Labels
A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@richvdh
Copy link
Member

richvdh commented Dec 13, 2021

currently, all postgres transactions are run in REPEATABLE READ isolation level, which is almost certainly more than we really need. The difficulty is the need to audit all of our transactions to check which actually need it.
@richvdh richvdh mentioned this issue Dec 13, 2021
Closed
@richvdh
Copy link
Member Author

richvdh commented Dec 13, 2021

per #4473:

Maybe we could do this with an option to runInteraction which indicates whether we need to change the isolation level (defaulting to "yes"). Over time we can go through our transactions and turn the option off for transactions we are happy don't require this.

@babolivier babolivier mentioned this issue Dec 13, 2021
Closed
@clokep
Copy link
Member

clokep commented Dec 13, 2021

Maybe related to #4993?

@reivilibre reivilibre added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Dec 14, 2021
This was referenced Jan 19, 2022
Closed
Merged
@MadLittleMods MadLittleMods added the A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db label Jun 3, 2022
@richvdh richvdh mentioned this issue Jun 9, 2022
Merged
4 tasks
@realtyem realtyem mentioned this issue Jun 25, 2023
Merged
4 tasks
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clokep @MadLittleMods @richvdh @reivilibre