Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

drop dependency on mock >= 4.0 #11614

Closed
richvdh opened this issue Dec 20, 2021 · 1 comment · Fixed by #11588
Closed

drop dependency on mock >= 4.0 #11614

richvdh opened this issue Dec 20, 2021 · 1 comment · Fixed by #11588
Labels
X-Release-Blocker Must be resolved before making a release

Comments

@richvdh
Copy link
Member

richvdh commented Dec 20, 2021

We have promised our downstream packagers we will drop our dependency on mock >= 4.0 in Synapse 1.50, since at the time, we believed it to be redundant as of Python 3.7.

That doesn't actually seem to be the case (unittest.mock.__aenter__ and friends were only added in Python 3.8), but we still need to solve this problem (In short, Fedora doesn't package recent versions of mock: https://fedoraproject.org/wiki/Changes/DeprecatePythonMock.)

(for links: the dep on mock 4.0 was introduced in #11306).

@richvdh richvdh added the X-Release-Blocker Must be resolved before making a release label Dec 20, 2021
@richvdh
Copy link
Member Author

richvdh commented Dec 20, 2021

#11588 contains a fix for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker Must be resolved before making a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant