Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Admin API Override ratelimiting for users should allow overriding more than the equivalent of rc_message #11785

Open
Gnuxie opened this issue Jan 20, 2022 · 2 comments
Labels
A-Admin-API A-Moderation Tools for moderating HSes: event redaction, media removal, purge admin API, reports from users, ... O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@Gnuxie
Copy link

Gnuxie commented Jan 20, 2022

Description:

https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html#override-ratelimiting-for-users

This API seems to only allow overriding limits consistent with rc_message and none of the other options that are available in homeserver,yaml.

Crucially though this excludes at least:

  • sending state events
  • creating rooms

I'm not sure of the rate limits in homeserver.yaml they apply to.

Other things that would be nice to disable selectively (for integration tests and have less justification than the above) are:

  • logging in and out (rc_login)
  • joining and leaving rooms (rc_joins)
@anoadragon453 anoadragon453 added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Jan 24, 2022
@callahad
Copy link
Contributor

@Gnuxie Is this a nice-to-have, or is there a specific driver for this request?

@callahad callahad added the P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches label Jan 27, 2022
@Gnuxie
Copy link
Author

Gnuxie commented Jan 28, 2022

Hi @callahad , I think it's a nice to have. We have recently started testing Mjolnir with rate limiting but didn't want to slow down all of our tests by changing all of the global rate limits. To me it is "good enough" to test with just rc_message but it's still a little sketchy. At the least the documentation should probably make it clear that the endpoint only overrides the equivalent of rc_message.

@MadLittleMods MadLittleMods added A-Admin-API A-Moderation Tools for moderating HSes: event redaction, media removal, purge admin API, reports from users, ... S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches labels Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Admin-API A-Moderation Tools for moderating HSes: event redaction, media removal, purge admin API, reports from users, ... O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

4 participants