Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Implement MSC3772: Push rule for mutually related events #12551

Closed
4 tasks
clokep opened this issue Apr 26, 2022 · 3 comments · Fixed by #14094
Closed
4 tasks

Implement MSC3772: Push rule for mutually related events #12551

clokep opened this issue Apr 26, 2022 · 3 comments · Fixed by #14094
Assignees
Labels
A-Threads Threaded messages T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@clokep
Copy link
Member

clokep commented Apr 26, 2022

MSC3772 augments push rules with additional checks.

To implement we need to:

  • Implement the new push rule condition.
  • Add the additional default push rules:
    • .m.rule.thread_reply_to_me
    • .m.rule.thread_reply

Depends on #11804.

@clokep clokep added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. A-Threads Threaded messages labels Apr 26, 2022
@clokep clokep self-assigned this Apr 26, 2022
@clokep
Copy link
Member Author

clokep commented May 9, 2022

I think the new push rule condition either needs some changes to the push infrastructure to allow it to dynamically fetch more info or it needs to pull from event_relations to see what unique groups of (rel_type, sender, type); this could be a lot of information, however.

We might be able to pre-process conditions to see what we need to pull though and then only have a cache of booleans. Still sounds somewhat expensive though.

@clokep
Copy link
Member Author

clokep commented Sep 6, 2022

This is no longer planned at the moment.

@clokep clokep removed their assignment Sep 6, 2022
@daniellekirkwood
Copy link

The team made a decision for the Exit Beta Milestone and we landed here: https://docs.google.com/document/d/1DYyDsf24OlrME3h-Hg-H2GvCrKkqZJrQwIbNWjqxB2A/edit?usp=sharing

therefore we do not need to move forwards with this issue at this stage. It's an enhancement for the future so I will mark it as such! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Threads Threaded messages T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants