Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Shutdown room API should avoid generating notifications #12622

Closed
t3chguy opened this issue May 3, 2022 · 10 comments
Closed

Shutdown room API should avoid generating notifications #12622

t3chguy opened this issue May 3, 2022 · 10 comments
Labels
A-Admin-API O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@t3chguy
Copy link
Member

t3chguy commented May 3, 2022

The shutdown room API can cause useless notifications since the homeserver is going to be mass kicking all users anyway.


Moved from element-hq/element-web#6996

@anoadragon453
Copy link
Member

Sorry, what does the "mute the room" actually mean?

I'm not sure what this issue is asking for.

@anoadragon453 anoadragon453 added the X-Needs-Info This issue is blocked awaiting information from the reporter label May 5, 2022
@t3chguy
Copy link
Member Author

t3chguy commented May 5, 2022

Pinging @ara4n for more info

@H-Shay
Copy link
Contributor

H-Shay commented Jun 1, 2022

This is 30 days old with no updates and seems to come from a 2-year-old issue in element-web, so unless anyone strongly disagrees I am going to close this issue.

@H-Shay H-Shay closed this as completed Jun 1, 2022
@t3chguy
Copy link
Member Author

t3chguy commented Jun 1, 2022

Keep in mind this is a feature request from @ara4n

@t3chguy
Copy link
Member Author

t3chguy commented Jun 1, 2022

Presumably mute in this context is to set the permissions required to speak out of bounds of local users

@H-Shay
Copy link
Contributor

H-Shay commented Jun 1, 2022

I'll reopen no problem.

@H-Shay H-Shay reopened this Jun 1, 2022
@clokep clokep changed the title shutdown room API should mute rooms before masskicking Shutdown room API should avoid generating notifications Aug 24, 2022
@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Aug 24, 2022
@clokep
Copy link
Member

clokep commented Aug 24, 2022

I've attempted to clarify this issue a bit -- as is mentioned in the Element Web issue I'm not sure what could be done over federation here, but it seems like something useful could be done for local users.

@richvdh
Copy link
Member

richvdh commented Aug 25, 2022

Hum; I'm still not sure we're clear what this issue is actually asking for.

Presumably mute in this context is to set the permissions required to speak out of bounds of local users

This doesn't sound like notifications - rather it's about setting the power levels in the room so that users can't send messages in the first place. I think the problem is that kicking can take a long time, so people can still send messages while it's going on, which isn't terribly helpful.

@clokep
Copy link
Member

clokep commented Aug 25, 2022

Presumably mute in this context is to set the permissions required to speak out of bounds of local users

This doesn't sound like notifications - rather it's about setting the power levels in the room so that users can't send messages in the first place. I think the problem is that kicking can take a long time, so people can still send messages while it's going on, which isn't terribly helpful.

That's a possible interpretation of the original request too. This sounds like #11842, which is fixed.

@DMRobertson
Copy link
Contributor

Closing as a duplicate of #11842. If @ara4n had something specific in mind that wasn't covered by this, a new issue is very welcome.

@DMRobertson DMRobertson closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Admin-API O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

7 participants