Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Faster joins: stuck "partial state room" if persisting the /send_join response fails #12998

Closed
richvdh opened this issue Jun 9, 2022 · 2 comments · Fixed by #13403
Closed

Faster joins: stuck "partial state room" if persisting the /send_join response fails #12998

richvdh opened this issue Jun 9, 2022 · 2 comments · Fixed by #13403
Assignees
@reivilibre
Labels
A-Federated-Join joins over federation generally suck T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Milestone
Q3 2022: Faster j...

Comments

@richvdh
Copy link
Member

richvdh commented Jun 9, 2022 •
edited
Loading

If the response to /send_join turns out to be invalid (so processing it fails), we end up with a room stuck in the "partial state" state.

part of #12646
@richvdh richvdh added A-Federated-Join joins over federation generally suck T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jun 9, 2022
@richvdh
Copy link
Member Author

richvdh commented Jun 9, 2022 •
edited
Loading

synapse/synapse/handlers/federation.py

Lines 545 to 549 in 7c6b220

if ret.partial_state:
# TODO(faster_joins): roll this back if we don't manage to start the
# background resync (eg process_remote_join fails)
# https://github.com/matrix-org/synapse/issues/12998
await self.store.store_partial_state_room(room_id, ret.servers_in_room)

@richvdh
Copy link
Member Author

richvdh commented Jul 22, 2022

I think this is relatively low-hanging fruit which someone could pick up without too much introduction

@reivilibre reivilibre self-assigned this Jul 27, 2022
@reivilibre reivilibre mentioned this issue Jul 27, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@reivilibre reivilibre

Labels
A-Federated-Join joins over federation generally suck T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
Q3 2022: Faster joins: fix major know...
Development

Successfully merging a pull request may close this issue.

Faster Room Joins: don't leave a stuck room partial state flag if the join fails. matrix-org/synapse
2 participants
@richvdh @reivilibre