Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't pull out state in compute_event_context for unconflicted state #13252

Closed
erikjohnston opened this issue Jul 12, 2022 · 0 comments · Fixed by #13267
Closed

Don't pull out state in compute_event_context for unconflicted state #13252

erikjohnston opened this issue Jul 12, 2022 · 0 comments · Fixed by #13267
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@erikjohnston
Copy link
Member

When we compute the context of an event with only one prev event we pull out the full state from the DB:

if len(state_group_ids_set) == 1:
(state_group_id,) = state_group_ids_set
state = await self._state_storage_controller.get_state_for_groups(
state_group_ids_set
)

This often then goes unused, so we should stop doing that.

@erikjohnston erikjohnston added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jul 12, 2022
@erikjohnston erikjohnston added this to the Server Density milestone Jul 12, 2022
@clokep clokep changed the title Don't pull out state in compute_event_context for unconflicted stae Don't pull out state in compute_event_context for unconflicted state Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant